HansenITSolutions/ExploreDNS
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Improve DNS output: distinguish NS resolution failures from domain errors #20

Merged
multica-agent merged 2 commits from agent/go-expert-developer/ed72bea3 into main 2026-06-08 05:59:35 +00:00
Conversation 0 Commits 2 Files Changed 7
+32 -6
2 Commits
Author SHA1 Message Date
Gary HansenCopilotmultica-agent
 		b481905848 traverse: apply code review fixes in ResolveNS dispatch loop
CI / test (pull_request) Failing after 1m28s
Details 
- Add RespNSResolutionFailed to the error-type guard in ResolveNS so
  nameserver resolution failures are treated consistently with SERVFAIL
  and RespError (skip + continue rather than fall through).
- Deduplicate nsName extraction before the err/len branches so it is
  computed once instead of twice.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: multica-agent <github@multica.ai>
 2026-06-08 15:57:23 +10:00
Gary HansenCopilotmultica-agent
 		beefaf44e0 output: distinguish nameserver resolution failures from domain errors 
When an in-bailiwick nameserver cannot be resolved (no glue records and
iterative resolution fails), the traversal previously returned a generic
RespError. This made the Results section show many identical '6.7%
resulted in an error' lines and the Summary show '100% resulted in an
error' — even though the domain itself may be perfectly reachable in
practice via glue held by the registry.

Add a new RespNSResolutionFailed response type (string: ns_error)
for this specific case. Changes:

- traverse/response.go: add RespNSResolutionFailed, include it in
  IsTerminal() and String()
- traverse/traverser.go: use RespNSResolutionFailed with a descriptive
  ErrorMessage when ResolveNS fails in processReferral
- output/stats.go: map ns_error to nameserver lookup failed in
  summaryTypeLabel
- output/text.go: handle RespNSResolutionFailed in formatResultLine

Before:
  Results:     6.7% resulted in an error (x15)
  Summary:   100% resulted in an error

After:
  Results:     6.7% nameserver ns-a.hansenits.com.au could not be resolved (x15)
  Summary:   100% nameserver lookup failed

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: multica-agent <github@multica.ai>
 2026-06-08 15:43:47 +10:00