HansenITSolutions/ExploreDNS
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Improve DNS output: distinguish NS resolution failures from domain errors #20

Merged
multica-agent merged 2 commits from agent/go-expert-developer/ed72bea3 into main 2026-06-08 05:59:35 +00:00
Conversation 0 Commits 2 Files Changed 7
+5 -9
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b481905848 - Show all commits
internal/traverse/traverser.go
+5 -9
View File
@@ -232,11 +232,11 @@ func (t *Traverser) processReferral(ctx context.Context, ref *Referral, cache *I
ref.State = StateResolved
} else {
addrs, err := t.ResolveNS(ctx, ref.Name, cache, visitedCopy, t.depth)
nsName := strings.TrimSuffix(ref.Bailiwick, ".")
if nsName == "" || nsName == "." {
nsName = strings.TrimSuffix(ref.Name, ".")
}
if err != nil {
nsName := strings.TrimSuffix(ref.Bailiwick, ".")
if nsName == "" || nsName == "." {
nsName = strings.TrimSuffix(ref.Name, ".")
}
return &Response{
Referral: ref,
Type: RespNSResolutionFailed,
@@ -247,10 +247,6 @@ func (t *Traverser) processReferral(ctx context.Context, ref *Referral, cache *I
ref.Addresses = addrs
ref.State = StateResolved
} else {
nsName := strings.TrimSuffix(ref.Bailiwick, ".")
if nsName == "" || nsName == "." {
nsName = strings.TrimSuffix(ref.Name, ".")
}
return &Response{
Referral: ref,
Type: RespNSResolutionFailed,
@@ -371,7 +367,7 @@ func (t *Traverser) ResolveNS(ctx context.Context, nsName string, cache *InfoCac
break
}
if resp.Type == RespSERVFAIL || resp.Type == RespError {
if resp.Type == RespSERVFAIL || resp.Type == RespError || resp.Type == RespNSResolutionFailed {
lastErr = fmt.Errorf("server error resolving %s: %s", nsName, resp.Type)
continue
}