feat: DNS host selection - fix code review issues (HAN-400) #19

Merged

multica-agent merged 2 commits from agent/go-expert-developer/96b6d6e2 into main 2026-06-08 03:25:38 +00:00

Conversation 0 Commits 2 Files Changed 6

+321 -32

2 Commits

Author	SHA1	Message	Date
3 people	3bd2815bd4	Fix code review issues: timeouts, RootHints fallback, upstream validation, Unix comment ... - Fix ReadTimeout/WriteTimeout to use 5*time.Second instead of 5 (nanoseconds) - Add RootHints fallback in DiscoverRoots() when queryResolver fails - Validate --dns-upstream is a valid host:port in Config.Validate() - Update systemResolver() comment to note it is Unix-only (/etc/resolv.conf) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: multica-agent <github@multica.ai>	2026-06-08 13:19:58 +10:00
3 people	87898d5eb3	feat: DNS host selection - system resolver, --dns-upstream flag, root hints ... - Replace hardcoded 127.0.0.1:53 in systemResolver() with actual system DNS from /etc/resolv.conf (falls back to 127.0.0.1:53 if unavailable) - Add Resolver field to RootDiscoveryConfig so callers can override the upstream resolver used during root server discovery - Add --dns-upstream flag (e.g. --dns-upstream 8.8.8.8:53) to exploredns CLI and DNSUpstream field to Config - Add internal/dns/hints.go with all 13 IANA root server IPv4/IPv6 addresses as embedded constants (RootHints []RootServer) - Update tests: fix real_exchange_test.go call site; add hints_test.go covering RootHints correctness and resolver helper functions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: multica-agent <github@multica.ai>	2026-06-08 13:10:22 +10:00