5 Commits
Author SHA1 Message Date
fe74ec61a2 fix: remove tracked binaries covered by .gitignore
CI / test (pull_request) Failing after 3h3m3s
CI / docker (pull_request) Has been cancelled
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: multica-agent <github@multica.ai>
2026-06-17 22:05:30 +10:00
851203e8f6 fix: merge main into PR branch, resolve CI and go.mod conflicts
- Keep go-version-file: 'go.mod' from PR (reads Go version from go.mod)
- Keep gitea.hansenits.com.au module path in coverage check
- Pick up .gitignore bin/* entry from main
- go.mod: keep go 1.24.0 directive from main (GOTOOLCHAIN=local)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: multica-agent <github@multica.ai>
2026-06-17 22:05:16 +10:00
Gary cf280a9f2b fix: update .gitignore to include bin directory
CI / test (push) Failing after 3h6m19s
CI / docker (push) Has been cancelled
2026-06-17 12:11:11 +10:00
gary 1f23f482c1 Merge pull request 'fix: pin go directive to 1.24.0 and add GOTOOLCHAIN=local to CI (HAN-410)' (#25) from agent/go-expert-developer/6b3715f8 into main
CI / test (push) Failing after 3h1m13s
CI / docker (push) Has been cancelled
Reviewed-on: http://gitea.hansenits.com.au/hits/ExploreDNS/pulls/25
2026-06-10 10:14:16 +00:00
17e2c47e4a fix: pin go directive to 1.24.0 and add GOTOOLCHAIN=local to CI
CI / test (pull_request) Failing after 3h13m49s
CI / docker (pull_request) Has been cancelled
The CI was consistently failing because go.mod declared 'go 1.25.6',
which triggered Go's GOTOOLCHAIN=auto mechanism to auto-download Go
1.25.6 on the CI runner. That pre-release build lacks the 'covdata'
tool, causing 'go test -race -coverprofile=coverage.out ./...' to exit
non-zero on cmd/ packages (which have no test files), even though all
actual tests passed.

Fix:
- Lower go directive from 1.25.6 to 1.24.0 (minimum required by deps)
- Set go-version: '1.24' in setup-go to match
- Add GOTOOLCHAIN=local to every go command in ci.yml to prevent any
  further auto-download regardless of future go.mod changes

All tests pass locally with GOTOOLCHAIN=local.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: multica-agent <github@multica.ai>
2026-06-10 09:17:07 +10:00
5 changed files with 7 additions and 6 deletions
+5 -5
View File
@@ -18,21 +18,21 @@ jobs:
cache: true
- name: Vet
run: go vet ./...
run: GOTOOLCHAIN=local go vet ./...
- name: Test
run: go test -v -race -coverprofile=coverage.out ./...
run: GOTOOLCHAIN=local go test -v -race -coverprofile=coverage.out ./...
- name: Coverage report
run: go tool cover -func=coverage.out
run: GOTOOLCHAIN=local go tool cover -func=coverage.out
- name: Check internal package coverage
run: |
COVERAGE=$(go tool cover -func=coverage.out | grep "^gitea.hansenits.com.au/hits/ExploreDNS/internal" | awk '{print $3}' | sed 's/%//' | awk '{sum+=$1; count++} END {if(count>0) print sum/count; else print 0}')
COVERAGE=$(GOTOOLCHAIN=local go tool cover -func=coverage.out | grep "^gitea.hansenits.com.au/hits/ExploreDNS/internal" | awk '{print $3}' | sed 's/%//' | awk '{sum+=$1; count++} END {if(count>0) print sum/count; else print 0}')
echo "Average internal package coverage: ${COVERAGE}%"
- name: Build
run: go build -v ./...
run: GOTOOLCHAIN=local go build -v ./...
docker:
runs-on: ubuntu-latest
+1
View File
@@ -8,6 +8,7 @@
*.dll
*.so
*.dylib
bin/*
# Test binary, built with `go test -c`
*.test
BIN
View File
Binary file not shown.
Binary file not shown.
+1 -1
View File
@@ -1,6 +1,6 @@
module gitea.hansenits.com.au/hits/ExploreDNS
go 1.25.6
go 1.24.0
require (
github.com/miekg/dns v1.1.72