feat: implement referral resolution for nameserver names without glue records (HAN-381) (#7)
CI / test (push) Failing after 2m58s

Co-authored-by: Hansen IT Solutions <gary@hansenits.com>
Co-committed-by: Hansen IT Solutions <gary@hansenits.com>
This commit was merged in pull request #7.
This commit is contained in:
2026-06-07 06:09:49 +00:00
committed by multica-agent
parent 39529dacbb
commit feb5c68b39
3 changed files with 360 additions and 3 deletions
+160
View File
@@ -1,9 +1,12 @@
package traverse
import (
"context"
"fmt"
"net"
"strings"
"github.com/hits/ExploreDNS/internal/dns"
miekgdns "github.com/miekg/dns"
)
@@ -76,3 +79,160 @@ func (r *Referral) SetAddresses(addrs []net.IP) {
r.State = StateUnresolved
}
}
type CircularReferralError struct {
Name string
Chain []string
}
func (e *CircularReferralError) Error() string {
return fmt.Sprintf("circular referral detected for %s: %v", e.Name, e.Chain)
}
type UnresolvableNameserverError struct {
Name string
Reason string
}
func (e *UnresolvableNameserverError) Error() string {
return fmt.Sprintf("unresolvable nameserver %s: %s", e.Name, e.Reason)
}
func (r *Referral) Resolve(ctx context.Context, traverser *Traverser, cache *InfoCache, visited map[string]bool, depth int) error {
if r.HasAddresses() {
r.State = StateResolved
return nil
}
if cache != nil {
if addrs := cache.LookupGlue(r.Name); len(addrs) > 0 {
r.Addresses = addrs
r.State = StateResolved
return nil
}
}
if visited != nil {
if visited[r.Name] {
return &CircularReferralError{
Name: r.Name,
Chain: getVisitedNames(visited),
}
}
visited[r.Name] = true
}
if depth > DefaultMaxDepth {
return &UnresolvableNameserverError{
Name: r.Name,
Reason: "max depth exceeded",
}
}
roots, err := traverser.discoverRoots(ctx)
if err != nil {
return fmt.Errorf("root discovery: %w", err)
}
initial := NewReferral(r.Name, dns.TypeA, ".", 0, 1.0, nil)
initial.Addresses = roots
initial.State = StateResolved
stack := NewStack(DefaultMaxDepth)
stack.Push(initial)
traversalCache := NewInfoCache(nil)
if visited != nil {
for name := range visited {
traversalCache.StoreGlue(name, []net.IP{})
}
}
var lastErr error
for {
select {
case <-ctx.Done():
return fmt.Errorf("resolution cancelled: %w", ctx.Err())
default:
}
ref := stack.Pop()
if ref == nil {
break
}
cacheForStep := traversalCache
if ref.Parent != nil {
cacheForStep = traversalCache.Child()
}
resp := traverser.processReferral(ctx, ref, cacheForStep)
if resp.Type == RespAnswer {
if len(resp.Decoded.Answers) > 0 {
var addrs []net.IP
for _, rr := range resp.Decoded.Answers {
if a, ok := rr.(*miekgdns.A); ok {
addrs = append(addrs, a.A)
}
if aaaa, ok := rr.(*miekgdns.AAAA); ok {
addrs = append(addrs, aaaa.AAAA)
}
}
if len(addrs) > 0 {
r.Addresses = addrs
r.State = StateResolved
if cache != nil {
cache.StoreGlue(r.Name, addrs)
}
return nil
}
}
}
if resp.Type == RespNXDOMAIN {
lastErr = &UnresolvableNameserverError{
Name: r.Name,
Reason: "NXDOMAIN",
}
break
}
if resp.Type == RespSERVFAIL || resp.Type == RespError {
lastErr = fmt.Errorf("server error resolving %s: %s", r.Name, resp.Type)
continue
}
if resp.Type == RespReferral {
children := resp.ChildReferrals()
for _, child := range children {
if visited != nil && visited[child.Name] {
continue
}
if !stack.Push(child) {
lastErr = &UnresolvableNameserverError{
Name: r.Name,
Reason: "max depth exceeded during resolution",
}
}
}
}
}
if lastErr != nil {
return lastErr
}
return &UnresolvableNameserverError{
Name: r.Name,
Reason: "resolution exhausted without answer",
}
}
func getVisitedNames(visited map[string]bool) []string {
var names []string
for name := range visited {
names = append(names, name)
}
return names
}