Fix code review issues: timeouts, RootHints fallback, upstream validation, Unix comment
CI / test (pull_request) Failing after 1m30s
CI / test (pull_request) Failing after 1m30s
- Fix ReadTimeout/WriteTimeout to use 5*time.Second instead of 5 (nanoseconds) - Add RootHints fallback in DiscoverRoots() when queryResolver fails - Validate --dns-upstream is a valid host:port in Config.Validate() - Update systemResolver() comment to note it is Unix-only (/etc/resolv.conf) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: multica-agent <github@multica.ai>
This commit is contained in:
co-authored by
Copilot
multica-agent
parent
87898d5eb3
commit
3bd2815bd4
@@ -130,6 +130,12 @@ func (c *Config) Validate() error {
|
||||
return ErrAlwaysTCPRequiresTCP
|
||||
}
|
||||
|
||||
if c.DNSUpstream != "" {
|
||||
if _, _, err := net.SplitHostPort(c.DNSUpstream); err != nil {
|
||||
return fmt.Errorf("--dns-upstream %q is not a valid host:port address", c.DNSUpstream)
|
||||
}
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user